nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591164934
##########
configure.ps1:
##########
@@ -145,6 +150,17 @@ $WithClouseau = $(If ($EnableClouseau) {1} else {0})
$Hostname = [System.Net.Dns]::GetHostEntry([string]"localhost").HostName
$WithProper = (-not $DisableProper).ToString().ToLower()
$ErlangMD5 = ($EnableErlangMD5).ToString().ToLower()
+$WithSpiderMonkey = (-not $DisableSpiderMonkey).ToString().ToLower()
+
+if ($JSEngine -eq "quickjs") {
+ $WithSpiderMonkey = "false"
+}
+
+# If spidermonkey was disabled but JS_ENGINE set to "spidermonkey", reset it
to "quickjs"
+if ( ($WithSpiderMonkey -eq "false" ) -and ($JS_ENGINE -eq "spidermonkey" ) ) {
+ Write-Verbose "NOTICE: Spidermonkey was disabled, but
JS_ENGINE=spidermonkey. Setting JS_ENGINE=quickjs"
+ $JS_ENGINE = "quickjs"
+}
Review Comment:
Good find, Ronny! This actually fixes an bug, as well, since in other parts
of the config file we use `$JsEngine` already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
