nickva opened a new pull request, #5143: URL: https://github.com/apache/couchdb/pull/5143
Local external calls are fairly simple: it's when we use the function in the module via the external reference. Previously, with hotcode upgrades that might have made sense, but currently it doesn't, maybe even adds a tiny bit of overhead on each call. A couple of these were cleaned up in chttpd module. Unused externals are functions which are exported but not used anywhere. In some cases we didn't even use the function at all, like in the case of `stream_init/1,2` or `rexi:stream/1,2,3` we can remove their bodies as well. Since `stream_init` is removed, update the `init_stream` as per https://github.com/apache/couchdb/issues/5122, where we noticed that the newer `init_stream` doesn't actually update the timeout metric, so before cleaning up `stream_init` move that to the `init_stream`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
