nickva commented on code in PR #5160:
URL: https://github.com/apache/couchdb/pull/5160#discussion_r1702080691
##########
src/fabric/src/fabric_streams.erl:
##########
@@ -165,10 +177,7 @@ handle_stream_start(rexi_STREAM_INIT, {Worker, From}, St)
->
{stop, St#stream_acc{workers = [], ready = Ready1}}
end
end;
-handle_stream_start({ok, Error}, _, St) when Error == ddoc_updated; Error ==
insufficient_storage ->
- WaitingWorkers = [W || {W, _} <- St#stream_acc.workers],
- ReadyWorkers = [W || {W, _} <- St#stream_acc.ready],
- cleanup(WaitingWorkers ++ ReadyWorkers),
Review Comment:
I debated for a bit adding all those explicit cases for "non-success"
responses but figured it also makes sense to have a general "whatever else
happens we clean up" clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
