jiahuili430 commented on code in PR #5171:
URL: https://github.com/apache/couchdb/pull/5171#discussion_r1704362719
##########
src/couch/src/couch_bt_engine_header.erl:
##########
@@ -282,8 +282,13 @@ upgrade_epochs(#db_header{} = Header) ->
% compaction proceeds. In that case the epochs sequence could
% be regressing.
Epochs0;
- [{_OtherNode, S} | _] = Epochs1 ->
- assert_monotonic_update_seq(Header, S),
+ [{_OtherNode, S} | _] = Epochs0 when Header#db_header.update_seq <
S ->
Review Comment:
Thanks for adding the clause here, this is much better than a try-catch
block.
Q: It is monotonic, so it will never = S?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
