jaydoane commented on code in PR #5172:
URL: https://github.com/apache/couchdb/pull/5172#discussion_r1704512635
##########
src/couch/src/couch_lru.erl:
##########
@@ -15,33 +15,35 @@
-include("couch_server_int.hrl").
--type cache() :: {gb_trees:tree(), #{binary() => pos_integer()}}.
+-type cache() :: {gb_trees:tree(), #{binary() => pos_integer()}, integer()}.
Review Comment:
I'd be tempted to make Counter the first element, similar to how gb_trees
puts the size first, and since its more closely associated with the tree than
the map. Also since it starts at zero, is it more specifically a
`non_negative_integer()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
