nickva commented on code in PR #5179:
URL: https://github.com/apache/couchdb/pull/5179#discussion_r1719893501
##########
src/fabric/src/fabric_streams.erl:
##########
@@ -95,16 +95,23 @@ start(Workers0, Keypos, StartFun, Replacements, RingOpts) ->
cleanup(Workers) ->
% Stop the auxiliary cleaner process as we got to the point where cleanup
- % happesn in the regular fashion so we don't want to send 2x the number
kill
- % messages
+ % happens in the regular fashion and we don't want to send 2x the number
Review Comment:
Thanks, @big-r81 !
##########
src/fabric/src/fabric_streams.erl:
##########
@@ -95,16 +95,23 @@ start(Workers0, Keypos, StartFun, Replacements, RingOpts) ->
cleanup(Workers) ->
% Stop the auxiliary cleaner process as we got to the point where cleanup
- % happesn in the regular fashion so we don't want to send 2x the number
kill
- % messages
+ % happens in the regular fashion and we don't want to send 2x the number
+ % kill messages.
+ %
+ % First, we run the cleanup/1 function, then, we stop the cleaner;
+ % otherwise there a tiny risk we get killed after we stop the process and
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
