nickva commented on code in PR #5220:
URL: https://github.com/apache/couchdb/pull/5220#discussion_r1747239515


##########
src/mango/test/mango.py:
##########
@@ -120,6 +120,8 @@ def recreate(self):
                     # db exists and it is empty -- exit condition is met
                     return
                 self.delete()
+            else:
+                r.raise_for_status()

Review Comment:
   It would depend on what return codes we expect to get here. The retry loop 
was added to handle [intermittent 
failures](https://github.com/apache/couchdb/commit/0414ef3e5d39de159cb6e985110773ea5522aea4)
 most so we wouldn't want to bring back flakiness here.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to