nickva commented on code in PR #5286:
URL: https://github.com/apache/couchdb/pull/5286#discussion_r1792547704
##########
src/nouveau/src/nouveau_fabric_search.erl:
##########
@@ -39,13 +39,20 @@ go(DbName, #doc{} = DDoc, IndexName, QueryArgs0) ->
Shards = get_shards(DbName, QueryArgs0),
{PackedBookmark, #{limit := Limit, sort := Sort} = QueryArgs1} =
maps:take(bookmark, QueryArgs0),
+ TopN = maps:get(top_n, QueryArgs1, 10),
Review Comment:
If you want could pull the `?TOP_N_DEFAULT` into a define just to keep the
numeric constants at the top of the module. It's more verbose but it's the
pattern we use often in other modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
