nickva commented on code in PR #5372:
URL: https://github.com/apache/couchdb/pull/5372#discussion_r1900191075
##########
mix.exs:
##########
@@ -85,20 +81,29 @@ defmodule CouchDBTest.Mixfile do
# Run "mix help deps" to learn about dependencies.
defp deps() do
- deps_list = [
+ deps1 = [
{:junit_formatter, "~> 3.0", only: [:dev, :test, :integration]},
{:httpotion, ">= 3.1.3", only: [:dev, :test, :integration], runtime:
false},
{:excoveralls, "~> 0.12", only: :test},
- {:b64url, path: path("b64url")},
- {:jiffy, path: path("jiffy")},
- {:jwtf, path: path("jwtf")},
{:ibrowse, path: path("ibrowse"), override: true},
{:credo, "~> 1.7.7", only: [:dev, :test, :integration], runtime: false}
]
+ extra_deps = [:b64url, :jiffy, :jwtf, :meck, :mochiweb]
+ deps2 = Enum.map(extra_deps, &{&1, path: path(&1)})
+
+ deps_list =
+ if System.get_env("CI") do
Review Comment:
Wonder why we need this. Ideally a CI run shouldn't look too much different
than a local dev run, otherwise it could become tricky to debug things locally
(works in CI but not locally, or works locally but fail in CI) so could be
result in some frustration down the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]