nickva commented on code in PR #5373:
URL: https://github.com/apache/couchdb/pull/5373#discussion_r1902070341
##########
src/couch/src/couch_file.erl:
##########
@@ -152,60 +161,40 @@ assemble_file_chunk_and_checksum(Bin) ->
%%----------------------------------------------------------------------
%% Purpose: Reads a term from a file that was written with append_term
%% Args: Pos, the offset into the file where the term is serialized.
-%% Returns: {ok, Term}
-%% or {error, Reason}.
+%% Returns: {ok, Term}, {error, Error} or throws an error
Review Comment:
> Just a nano-quibble, but I'm seeing previous coverage from main via make
eunit apps=couch
Oh good catch. I only checked with the specific couch_file_tests module not
the whole couch app. The extra tests in
> Did you consider converting these to specs?
Without a regularly running dialyzer in CI it’s more of a hassle I think,
there is a chance we’d add wrong types. Maybe better for another PR that does
more of a spec improvement/cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
