nickva commented on code in PR #5394:
URL: https://github.com/apache/couchdb/pull/5394#discussion_r1912536713


##########
test/elixir/test/search_test.exs:
##########
@@ -71,7 +71,7 @@ defmodule SearchTest do
 
     url = "/#{db_name}/_design/inventory/_search/fruits"
     resp = Couch.get(url, query: %{q: "*:*", include_docs: true})
-    assert resp.status_code == 200
+    retry_until(fn -> resp.status_code == 200 end)

Review Comment:
   How does retry_until work? Do it have any magic to throw an exception and 
the whole test body up to that point is retried. Otherwise, if it's as simple 
as it looks in `retry_until(fn -> resp.status_code == 200 end)` we'd just be 
checking the same response and always fail, then we'd have to retry the whole 
`Couch.get(...)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to