jaydoane commented on code in PR #5417:
URL: https://github.com/apache/couchdb/pull/5417#discussion_r1932747508
##########
src/dreyfus/src/clouseau_rpc.erl:
##########
@@ -294,7 +294,21 @@ connected() ->
true;
false ->
% We might have just booted up, so let's ping
- pong == net_adm:ping(clouseau())
+ case net_adm:ping(clouseau()) of
+ pong ->
+ % We can ping, but is the main process up?
+ %
+ % In versions 2.x (at least) this was a possibility
+ % > clouseau_rpc:version().
+ % {'EXIT',noconnection}
+ %
+ case (catch version()) of
+ {ok, _} -> true;
Review Comment:
Haha was just trying to suggest that change and you beat me to it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
