nickva commented on PR #5399:
URL: https://github.com/apache/couchdb/pull/5399#issuecomment-2664185108
For property tests comparing behavior of cfile handles vs raw Erlang file
handles, I increased to test number to 10M from the default 25k. The test ran
for about 30 min and passed as well:
```diff
git diff src/couch/include/couch_eunit_proper.hrl
src/couch/test/eunit/couch_cfile_prop_tests.erl
diff --git a/src/couch/include/couch_eunit_proper.hrl
b/src/couch/include/couch_eunit_proper.hrl
index dcf07701a..86d9b245b 100644
--- a/src/couch/include/couch_eunit_proper.hrl
+++ b/src/couch/include/couch_eunit_proper.hrl
@@ -19,7 +19,7 @@
atom_to_list(F),
{timeout, QuickcheckTimeout,
?_assert(proper:quickcheck(?MODULE:F(), [
- {to_file, user},
+ %{to_file, user},
{start_size, 2},
{numtests, NumTests},
long_result
diff --git a/src/couch/test/eunit/couch_cfile_prop_tests.erl
b/src/couch/test/eunit/couch_cfile_prop_tests.erl
index a2d954e5c..9ada2d8fa 100644
--- a/src/couch/test/eunit/couch_cfile_prop_tests.erl
+++ b/src/couch/test/eunit/couch_cfile_prop_tests.erl
@@ -19,7 +19,7 @@
-include_lib("kernel/include/file.hrl").
property_test_() ->
- ?EUNIT_QUICKCHECK(60, 25000).
+ ?EUNIT_QUICKCHECK(3600, 10000000).
```
```
======================= EUnit ========================
module 'couch_cfile_prop_tests'
couch_cfile_prop_tests:22: -property_test_/0-fun-2-
(prop_file_ops_results_match_raw_file)...[1722.006 s] ok
[done in 1723.859 s]
=======================================================
Test passed.
Cover analysis: /Users/nvatama/asf/src/couch/.eunit/index.html
Code Coverage:
couch_cfile_prop_tests : 98%
Total : 98%
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
