pgj commented on code in PR #5510:
URL: https://github.com/apache/couchdb/pull/5510#discussion_r2055784447
##########
src/mango/src/mango_cursor.erl:
##########
@@ -583,6 +585,9 @@ ddoc_name(<<"_design/", Name/binary>>) ->
ddoc_name(Name) ->
Name.
+set_from_list(KVs) ->
Review Comment:
Would not it be better to move this definition to some shared utility module
instead of duplicating its definition in multiple modules? One could include a
similar wrapper for `sets:new([{version, 2}])` (as e.g. `set_new/0`) to extend
consistency to the creation of sets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
