nickva commented on PR #5516:
URL: https://github.com/apache/couchdb/pull/5516#issuecomment-2832287185

   > Do I understand properly that this metric type will be `gauge`. More info 
[metric types](https://prometheus.io/docs/concepts/metric_types/).
   > 
   
   Yeah that seemed most appropriate as the value can toggle between 1 and back 
to 0.
   
   > Could you add a metrics description to the exporter output like
   > 
   > ```
   > # HELP couchdb_membership CouchDB nodes membership information.
   > # TYPE couchdb_membership gauge
   > couchdb_membership{nodes="cluster_nodes"} 3
   > couchdb_membership{nodes="all_nodes"} 3
   > ```
   
   
   Good idea there is a general description for couchdb_membership but maybe it 
should a separate metrics, couch_membership_nodes with it's own help line and 
such.
   
   > More info at [metric description 
example](https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#text-format-example)
   
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to