nickva commented on code in PR #5602: URL: https://github.com/apache/couchdb/pull/5602#discussion_r2219920633
########## src/couch_stats/src/csrt_httpd.erl: ########## @@ -0,0 +1,169 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except in compliance with the License. You may obtain a copy of +% the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +% License for the specific language governing permissions and limitations under +% the License. + +-module(csrt_httpd). +-include_lib("couch/include/couch_db.hrl"). +-include_lib("csrt.hrl"). + +-export([handle_resource_status_req/1]). + +-import( + chttpd, + [ + send_json/2, send_json/3, + send_method_not_allowed/2 + ] +). + +-import( + csrt, + [ + query/1, + from/1, + group_by/1, + group_by/2, + sort_by/1, + sort_by/2, + count_by/1, + options/1, + unlimited/0, + with_limit/1, + + run/1 + ] +). Review Comment: Avoid imports if possible. We use them in a few places in http code but they're not a great of a feature. For instance now we have a mix of full references like `csrt:rpc_run()` and `chttpd:verify_is_server_admin()` vs imported ones like `query()` and it seems kind of arbitrary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
