nickva opened a new pull request, #5615: URL: https://github.com/apache/couchdb/pull/5615
Previously, the scanner traversed docs by id, skipping deleted documents. However, some plugins like the conflict checker, or the finder, may want to inspect deleted docs. To fix this, switch to using by-seq order during scanning. This will also let us add more precise checkpoints in the future; we could, for example, checkpoint during the db traversal not just per-db. To let plugins customize the traversal, modify the db_opened/2 callback so it can return start changes sequence and changes folding options. Use this new feature in the finder since there it makes sense to scan backwards to find the most recently added data first (i.e. someone just added something they shouldn't have to the db and we'd like to find it). Since we now consider deleted documents, adjust the QuickJS scanner to discard deleted FDIs before even opening the doc bodies. For the conflict checker, add a test to ensure we do catch deleted conflicts when all of them are deleted. As minor tweak, improved the scanner tests by using `#doc{}` records instead of plain tuples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org