rnewson commented on PR #5625: URL: https://github.com/apache/couchdb/pull/5625#issuecomment-3199749004
Nice work. I'd like to see a bigger benchmark before deciding but the performance gain is quite modest (except for changes) to warrant the extra complexity and failure modes (on the flipside it does validate our deliberate reliance on the OS page cache for this so far). I'd be curious to see the same benchmarks but with the code modified to not expire the cached items so aggressively (to find the upper bound to how much this could improve things). It would also be useful to know how deep the btrees are in question (or some other indication of the cache hit/miss ratio to give us context when assessing the throughput figures). As for why changes gets such a boost, that needs some thinking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
