nickva commented on code in PR #5642:
URL: https://github.com/apache/couchdb/pull/5642#discussion_r2331345434


##########
rel/overlay/etc/default.ini:
##########
@@ -468,6 +475,8 @@ hash_algorithms = sha256, sha
 ;update_db = true
 
 ;[view_updater]
+;queue_memory_cap = 100000 ; `max_size` of couch_work_queue

Review Comment:
   Maybe add the comments before the values like for most of our settings 
instead of inline. 
   
   Also it may help users if we explain what couch_work_queue is. It can be 
something "maximum item count and memory size (in bytes) of the document 
changes and index update queues". 
   
   The general structure is something like:
    ```
       _changes feed ->[workqueue]-> map -> [workqueue] -> index write
   ```
   
   So we queue both the changes before and the writes after the mapper. The 
setting here are applied to both queues. For each queue whichever limit happens 
to be hit first is the one that take effect. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to