rnewson commented on code in PR #314: URL: https://github.com/apache/couchdb-nano/pull/314#discussion_r2333439525
########## lib/nano.js: ########## @@ -251,128 +238,119 @@ module.exports = exports = function dbScope (cfg) { log({ err: 'couch', body: message, headers: responseHeaders }) - stream.emit('error', error) + setTimeout(() => { + stream.emit('error', error) + }, 10) } - function relax (opts, callback) { + function relax (opts) { if (typeof opts === 'function') { - callback = opts opts = { path: '' } } - if (typeof opts === 'string') { opts = { path: opts } } - if (!opts) { opts = { path: '' } - callback = null } - const qs = Object.assign({}, opts.qs) + // the building blocks of the request + let body, uri + // construct headers object to be passed in the request const headers = { - 'content-type': 'application/json', + // 'content-type': 'application/json', Review Comment: why add new commented-out code here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org