nickva commented on code in PR #5702:
URL: https://github.com/apache/couchdb/pull/5702#discussion_r2440960339
##########
src/couch_replicator/test/eunit/couch_replicator_test_helper.erl:
##########
@@ -206,6 +206,7 @@ test_setup() ->
Hashed = couch_passwords:hash_admin_password(?PASSWORD),
Persist = false,
ok = config:set("admins", ?USERNAME, ?b2l(Hashed), Persist),
+ ok = config:set("replicator", "use_bulk_get", "true", Persist),
Review Comment:
In this case we'd probably just want to just want to reset it back after the
test is done. It will be semantic change, to look cleaner (we did some thing,
we undid it when done), but in reality since we're using persist false and
tests start new config application instance, it shouldn't make a practical
difference. This can be a separate PR or punt on it.
> I'll update the default.ini file
I don't think we need to update default.ini?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
