nickva commented on code in PR #5762:
URL: https://github.com/apache/couchdb/pull/5762#discussion_r2565694960
##########
src/config/src/config.erl:
##########
@@ -615,6 +594,58 @@ settings_fmap_fun({{?MODULE, ?SETTINGS, Sec, Key}, Val}) ->
settings_fmap_fun(_) ->
false.
+reload(Config) ->
+ #config{ini_files_dirs = IniFilesDirs} = Config,
+ IniFiles = expand_dirs(IniFilesDirs),
+ % Update ets with ini values.
+ IniMap = ini_map(IniFiles),
+ maps:foreach(
+ fun({Sec, Key}, V) ->
+ VExisting = get_value(Sec, Key, undefined),
+ put_value(Sec, Key, V),
Review Comment:
Wonder if this can be moved to the `false` case. The issue is constantly
updating put-ing persistent term values and triggering global gc across all the
processes using (unless persistent term logic has something to detect that it's
a no-op)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
