big-r81 commented on code in PR #199:
URL: https://github.com/apache/couchdb-pkg/pull/199#discussion_r2830590329
##########
Makefile:
##########
@@ -299,7 +322,7 @@ make-rpmbuild:
# If we don't change $HOME it'll force building in ~/rpmbuild. Boo.
build-rpm:
$(eval HOME := $(shell readlink -f ..))
- export HOME=$(HOME) && cd ../rpmbuild && rpmbuild --verbose -bb
SPECS/couchdb.spec --define '_version $(VERSION)'
+ export HOME=$(HOME) && cd ../rpmbuild && rpmbuild --verbose -bb
SPECS/couchdb.spec --define '_version $(VERSION)' --define '_js_engine
$(JS_ENGINE)'
Review Comment:
`SPIDERMONKEY, SPIDERMONKEY_DEV, SM_VER` are replaced via `sed` before, and
now I see that `SPIDERMONKEY_DEV` isn't set in the spec file at all. Can we
remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
