nickva commented on code in PR #5858:
URL: https://github.com/apache/couchdb/pull/5858#discussion_r3392347812
##########
src/couch_mrview/src/couch_mrview.erl:
##########
@@ -248,12 +248,11 @@ validate(Db, DDoc) ->
ok
end,
- try Views =/= [] andalso couch_query_servers:get_os_process(Lang) of
- false ->
- ok;
+ try couch_query_servers:get_os_process(Lang) of
Review Comment:
One change here to watch out for is that previously if ddoc didn't have
views we didn't check out an OS process. Now we always do. Could we first check
if we have views or a VDU and only then go into `get_os_process()`? Not a huge
deal but OS processes are a limited resource and it would nice not have get
them from the proc manager gen_server on every ddoc update if doesn't have
anything to validate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
