jcoglan commented on code in PR #6080:
URL: https://github.com/apache/couchdb/pull/6080#discussion_r3757719589
##########
src/mango/src/mango_native_proc.erl:
##########
@@ -95,6 +100,21 @@ handle_call({prompt, [<<"nouveau_index_doc">>, Doc]},
_From, St) ->
Else
end,
{reply, Vals, St};
+handle_call({prompt, [<<"validate_fun">>, Selector0 | _Rest]}, _From, St) ->
+ try mango_selector:normalize(Selector0) of
+ Selector ->
+ case validate_vdu(Selector) of
+ ok -> {reply, true, St};
+ Error -> {reply, {error, Error}, St}
+ end
+ catch
+ throw:{mango_error, mango_selector, {invalid_operator, Op}} ->
+ Msg = io_lib:format("invalid operator: ~p", [Op]),
+ {reply, {error, {compilation_error, Msg}}, St};
+ throw:{mango_error, mango_util, {invalid_field_name, Field}} ->
Review Comment:
Thanks, I've made the change you suggested and the error responses look
better now.
```
$ cdb '/asd/_design/vdu' -X PUT -d '{ "language": "query",
"validate_doc_update": { "newDoc.": { "$nope": 0 } } }' | jq
{
"error": "compilation_error",
"reason": "Compilation of the validate_doc_update function in the
'validate_doc_update' view failed: Invalid operator: $nope"
}```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
