glynnbird opened a new pull request, #374: URL: https://github.com/apache/couchdb-nano/pull/374
## Overview `db.attachment.get` is supposed to return a Promise that resolves to a Buffer, but for JSON attachments, as reported in issue #373, Nano gets too smart and returns a string - the JSON.parse'd data. This PR fixes the intention of the library - to return a Buffer for all attachment fetches. There was already a flag in place to indicate that JSON.parsing should be suspended, but it was ignored. ## Testing recommendations Automated test added to fetch a JSON attachment and to ensure it's a Buffer. ## GitHub issue number Fixes issue #373 ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [x] Documentation reflects the changes; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
