rnewson commented on code in PR #6096:
URL: https://github.com/apache/couchdb/pull/6096#discussion_r4092614765
##########
extra/nouveau/src/main/java/org/apache/couchdb/nouveau/lucene/LuceneIndex.java:
##########
@@ -181,6 +180,9 @@ public void doClose() throws IOException {
() -> {
writer.rollback();
},
+ () -> {
+ analyzer.close();
Review Comment:
very few of the analyzers actually do anything in close() so probably not in
practice, but it is still right to close them explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
