nickva commented on PR #6122:
URL: https://github.com/apache/couchdb/pull/6122#issuecomment-6643034687

   Another thing to look at is where we handle `chunked` responses with the 
plain `chunked` version. Test some of those with the gzip to see if they work 
properly:
   
   ```
   ~/asf-compression-server (pr/6122) % rg -w chunked | rg respond
   src/chttpd/src/chttpd.erl:    Resp = handle_response(Req, Code, Headers1, 
chunked, respond),
   src/chttpd/src/chttpd_node.erl:        {Ref, Code, Headers, chunked, 
respond} ->
   src/chttpd/src/chttpd_node.erl:            Resp = ReqResp:respond({Code, 
Headers, chunked}),
   src/couch/test/eunit/test_web.erl:            Resp = Req:respond({Status, 
Headers, chunked}),
   ```
   
   it seems at least `_node/_local` request forwarder logic should get clause 
like this maybe:
   
   ```erlang
   {Ref, Code, Headers, {chunked, _Codec} = Args, respond} ->
       Resp = ReqResp:respond({Code, Headers, Args}),
       recv_loop(Ref, Resp);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to