Baoqi commented on a change in pull request #1018: spotbugs: bug check and
modify
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1018#discussion_r336829581
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
##########
@@ -817,7 +817,7 @@ public void exportProcessDefinitionById(User loginUser,
String projectName, Inte
ProcessDefinition processDefinition =
processDefineMapper.selectById(defineId);
if (processDefinition == null) {
logger.info("process define not exists");
- putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST,
processDefinition.getId());
+ putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST);
Review comment:
Here, you can not omit the third parameter for putMsg (since the
PROCESS_DEFINE_NOT_EXIST need an additional parameter to replace {0}
Here you need to change to
putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, defineId);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
