dailidong commented on issue #1179: Master
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/1179#issuecomment-551427621
 
 
   thanks for contribution first!
   
   one feature one pr, and one pr changed so many files, nobody can review what 
have happened.
   
   It's better not to modify so many files at a time, it will scared who want 
to review(> 5 files changed).
   the pr title should clear what want to do about this pr! 
   
   you'd better resolve conflicting files locally
   
![image](https://user-images.githubusercontent.com/15833811/68459874-765a9880-0241-11ea-83a4-b449601380f0.png)
   
   thanks again!  it will be better next time!  haha

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to