satansk commented on issue #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691 URL: https://github.com/apache/incubator-dubbo/pull/1738#issuecomment-386638830 There's still one thing to mention, there are some typos in `MulticastRegister` which I did not correct this time: ```Java private final InetAddress mutilcastAddress; private final MulticastSocket mutilcastSocket; private final int mutilcastPort; ``` The reason that I did not correct them is they have some public method related to names, if modified, the public interface will be damaged. So what can we do here?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
