diecui1202 opened a new pull request #1759: fix #934 #1756 use loadBalance policy to choose invoke when providers less 2 URL: https://github.com/apache/incubator-dubbo/pull/1759 ## What is the purpose of the change 1. Use loadBalance policy when providers less 2 2. Fix AbstractClusterInvokerTest OutOfMemoryError ## Brief changelog 1. Remove the following code fragment in AbstractClusterInvoker.java : ```java - // If we only have two invokers, use round-robin instead. - if (invokers.size() == 2 && selected != null && !selected.isEmpty()) { - return selected.get(0) == invokers.get(0) ? invokers.get(1) : invokers.get(0); - } ``` 2. Add clear invocation operation after invoking in AbstractClusterInvokerTest.java : ``` Mockito.clearInvocations(invoker1, invoker2, invoker3, invoker4, invoker5); ``` ## Verifying this change All test cases are pass. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org