vangoleo commented on issue #96: MonitorFilter中获取并发数,未考虑到service分组的情况 URL: https://github.com/apache/incubator-dubbo/issues/96#issuecomment-389771146 Yes, the logic of collecting concurrent is incorrect. And the base issue is that currently, while collect statistics data, Dubbo don't consider the method overloading. It don't distinguish multiple methods with the same method name, but different method parameter types. For example, the client invoke below two methods: * invoke hello() method for 2 times. * invoke hello("tom") method for 5 times. Dubbo treats it that "hello" method is being called for 7 times. And the result shown in Dubbo monitor Web is also only one record "hello is called for 7 times"; Not only the invocation count and the concurrent, but also the success count, failure count, the average elapsed time, etc. In order to fix this issue, we need to change most logic of MonitorFilter and Dubbo Monitor Web.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
