chickenlj closed pull request #1811: [Dubbo-1667] Fix unstable hessian protocol
unit test. #1667
URL: https://github.com/apache/incubator-dubbo/pull/1811
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-rpc/dubbo-rpc-hessian/src/test/java/com/alibaba/dubbo/rpc/protocol/hessian/HessianProtocolTest.java
b/dubbo-rpc/dubbo-rpc-hessian/src/test/java/com/alibaba/dubbo/rpc/protocol/hessian/HessianProtocolTest.java
index 2ca3fce127..6e8ab72e17 100644
---
a/dubbo-rpc/dubbo-rpc-hessian/src/test/java/com/alibaba/dubbo/rpc/protocol/hessian/HessianProtocolTest.java
+++
b/dubbo-rpc/dubbo-rpc-hessian/src/test/java/com/alibaba/dubbo/rpc/protocol/hessian/HessianProtocolTest.java
@@ -25,7 +25,7 @@
import com.alibaba.dubbo.rpc.RpcException;
import com.alibaba.dubbo.rpc.protocol.hessian.HessianServiceImpl.MyException;
-import junit.framework.Assert;
+import org.junit.Assert;
import org.junit.Test;
import static org.junit.Assert.fail;
@@ -41,7 +41,7 @@ public void testHessianProtocol() {
Assert.assertFalse(server.isCalled());
ProxyFactory proxyFactory =
ExtensionLoader.getExtensionLoader(ProxyFactory.class).getAdaptiveExtension();
Protocol protocol =
ExtensionLoader.getExtensionLoader(Protocol.class).getAdaptiveExtension();
- URL url = URL.valueOf("hessian://127.0.0.1:5342/" +
HessianService.class.getName() + "?version=1.0.0");
+ URL url = URL.valueOf("hessian://127.0.0.1:5342/" +
HessianService.class.getName() + "?version=1.0.0&hessian.overload.method=true");
Exporter<HessianService> exporter =
protocol.export(proxyFactory.getInvoker(server, HessianService.class, url));
Invoker<HessianService> invoker = protocol.refer(HessianService.class,
url);
HessianService client = proxyFactory.getProxy(invoker);
@@ -76,7 +76,7 @@ public void testHttpClient() {
Assert.assertFalse(server.isCalled());
ProxyFactory proxyFactory =
ExtensionLoader.getExtensionLoader(ProxyFactory.class).getAdaptiveExtension();
Protocol protocol =
ExtensionLoader.getExtensionLoader(Protocol.class).getAdaptiveExtension();
- URL url = URL.valueOf("hessian://127.0.0.1:5342/" +
HessianService.class.getName() + "?version=1.0.0&client=httpclient");
+ URL url = URL.valueOf("hessian://127.0.0.1:5342/" +
HessianService.class.getName() +
"?version=1.0.0&client=httpclient&hessian.overload.method=true");
Exporter<HessianService> exporter =
protocol.export(proxyFactory.getInvoker(server, HessianService.class, url));
Invoker<HessianService> invoker = protocol.refer(HessianService.class,
url);
HessianService client = proxyFactory.getProxy(invoker);
@@ -100,7 +100,7 @@ public void testTimeOut() {
client.timeOut(6000);
fail();
} catch (RpcException expected) {
- Assert.assertEquals(true, expected.isTimeout());
+ Assert.assertTrue(expected.isTimeout());
} finally {
invoker.destroy();
exporter.unexport();
@@ -121,6 +121,7 @@ public void testCustomException() {
client.customException();
fail();
} catch (MyException expected) {
+
}
invoker.destroy();
exporter.unexport();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
