chickenlj opened a new pull request #1957: [Dubbo-1876] Enhancements for the new async way of Dubbo URL: https://github.com/apache/incubator-dubbo/pull/1957 ## What is the purpose of the change Enhancements for the new async way of Dubbo introduced in #1876. Below is the main issues this PR trys to resolve: - Support service signature with original CompletableFuture returntype. ```java public interface DemoService { CompletableFuture<String> sayHello(String name); } ``` - Provide context restore API when switching threads. ```java AsyncContext.signalContextSwitch(); ``` - Postprocess of async result in filter chain. ## Brief changelog - Add AsyncRpcResult to represent result value of async invoke, equivalent to RpcResult for sync invoke. - Add PostProcessFilter to support postprocess of result in filter chain - Change AbstractProxyInvoker and DubboInvoker to support services with original Future signature, supplementary for generated Future service. ## Verifying this change - Run samples for how to use async in a new way. - Still lack of UT, expect to add soon. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [X] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
