ningyu1 opened a new issue #1962: The validation format of parameters set in 
ReferenceConfig, ServiceConfig and RegistryConfig is inconsistent.
URL: https://github.com/apache/incubator-dubbo/issues/1962
 
 
   When the API is used, the format of parameter validation is inconsistent.
   
   Such as: SetGroup method
   
   AbstractReferenceConfig
   
   ```
       public void setGroup(String group) {
           checkKey("group", group);
           this.group = group;
       }
   ```
   
   RegistryConfig
   
   ```
       public void setGroup(String group) {
           this.group = group;
       }
   ```
   
   The following exception occurs when the group is: dubbo/TEST
   
   ```
   java.lang.IllegalStateException: Invalid group="dubbo/TEST" contain illegal 
charactor, only digit, letter, '-', '_' and '.' is legal.
   ```
   
   I don't know if it's intentional? Or is it a code problem? I can send PR if 
needed
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to