beiwei30 closed pull request #1982: [dubbo-1689]: Enhance the test coverage
part-10 : dubbo-plugin module
URL: https://github.com/apache/incubator-dubbo/pull/1982
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java
b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java
index 05656f9ae6..681f5224c7 100644
---
a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java
+++
b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java
@@ -83,7 +83,7 @@ private void startQosServer(URL url) {
int port = Integer.parseInt(url.getParameter(QOS_PORT,"22222"));
boolean acceptForeignIp =
Boolean.parseBoolean(url.getParameter(ACCEPT_FOREIGN_IP,"true"));
- Server server = org.apache.dubbo.qos.server.Server.getInstance();
+ Server server = Server.getInstance();
server.setPort(port);
server.setAcceptForeignIp(acceptForeignIp);
server.start();
@@ -92,4 +92,11 @@ private void startQosServer(URL url) {
//throw new RpcException("fail to start qos server", throwable);
}
}
+
+ /*package*/ void stopServer() {
+ if (hasStarted.compareAndSet(true, false)) {
+ Server server = Server.getInstance();
+ server.stop();
+ }
+ }
}
diff --git
a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java
b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java
index fae0ac4dad..4051698e06 100644
---
a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java
+++
b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java
@@ -61,7 +61,7 @@ private Server() {
private String welcome;
- private AtomicBoolean hasStarted = new AtomicBoolean();
+ private AtomicBoolean started = new AtomicBoolean();
/**
* welcome message
@@ -78,7 +78,7 @@ public int getPort() {
* start server, bind port
*/
public void start() throws Throwable {
- if (!hasStarted.compareAndSet(false, true)) {
+ if (!started.compareAndSet(false, true)) {
return;
}
boss = new NioEventLoopGroup(0, new DefaultThreadFactory("qos-boss",
true));
@@ -132,4 +132,8 @@ public void setAcceptForeignIp(boolean acceptForeignIp) {
public String getWelcome() {
return welcome;
}
+
+ public boolean isStarted() {
+ return started.get();
+ }
}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/GreetingCommand.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/GreetingCommand.java
index 8c515ee4cb..ff49804b75 100644
---
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/GreetingCommand.java
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/GreetingCommand.java
@@ -17,6 +17,10 @@
package org.apache.dubbo.qos.command;
+import org.apache.dubbo.qos.command.annotation.Cmd;
+
+
+@Cmd(name = "greeting", summary = "greeting message", example = {"greeting
dubbo",})
public class GreetingCommand implements BaseCommand {
@Override
public String execute(CommandContext commandContext, String[] args) {
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/HttpCommandDecoderTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/HttpCommandDecoderTest.java
new file mode 100644
index 0000000000..36d6650fb4
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/HttpCommandDecoderTest.java
@@ -0,0 +1,48 @@
+package org.apache.dubbo.qos.command.decoder;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import io.netty.handler.codec.http.FullHttpRequest;
+import io.netty.handler.codec.http.HttpHeaders;
+import io.netty.handler.codec.http.HttpMethod;
+import io.netty.handler.codec.http.HttpRequest;
+import org.apache.dubbo.qos.command.CommandContext;
+import org.junit.Test;
+
+import java.nio.charset.StandardCharsets;
+
+import static org.hamcrest.Matchers.arrayContaining;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class HttpCommandDecoderTest {
+ @Test
+ public void decodeGet() throws Exception {
+ HttpRequest request = mock(HttpRequest.class);
+ when(request.getUri()).thenReturn("localhost:80/test");
+ when(request.getMethod()).thenReturn(HttpMethod.GET);
+ CommandContext context = HttpCommandDecoder.decode(request);
+ assertThat(context.getCommandName(), equalTo("test"));
+ assertThat(context.isHttp(), is(true));
+ when(request.getUri()).thenReturn("localhost:80/test?a=b&c=d");
+ context = HttpCommandDecoder.decode(request);
+ assertThat(context.getArgs(), arrayContaining("b", "d"));
+ }
+
+ @Test
+ public void decodePost() throws Exception {
+ FullHttpRequest request = mock(FullHttpRequest.class);
+ when(request.getUri()).thenReturn("localhost:80/test");
+ when(request.getMethod()).thenReturn(HttpMethod.POST);
+ when(request.headers()).thenReturn(HttpHeaders.EMPTY_HEADERS);
+ ByteBuf buf = Unpooled.copiedBuffer("a=b&c=d", StandardCharsets.UTF_8);
+ when(request.content()).thenReturn(buf);
+ CommandContext context = HttpCommandDecoder.decode(request);
+ assertThat(context.getCommandName(), equalTo("test"));
+ assertThat(context.isHttp(), is(true));
+ assertThat(context.getArgs(), arrayContaining("b", "d"));
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/TelnetCommandDecoderTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/TelnetCommandDecoderTest.java
new file mode 100644
index 0000000000..e9aed83fae
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/TelnetCommandDecoderTest.java
@@ -0,0 +1,19 @@
+package org.apache.dubbo.qos.command.decoder;
+
+import org.apache.dubbo.qos.command.CommandContext;
+import org.junit.Test;
+
+import static org.hamcrest.Matchers.arrayContaining;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+
+public class TelnetCommandDecoderTest {
+ @Test
+ public void testDecode() throws Exception {
+ CommandContext context = TelnetCommandDecoder.decode("test a b");
+ assertThat(context.getCommandName(), equalTo("test"));
+ assertThat(context.isHttp(), is(false));
+ assertThat(context.getArgs(), arrayContaining("a", "b"));
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/HelpTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/HelpTest.java
new file mode 100644
index 0000000000..180a144fcc
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/HelpTest.java
@@ -0,0 +1,32 @@
+package org.apache.dubbo.qos.command.impl;
+
+import org.apache.dubbo.qos.command.CommandContext;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+public class HelpTest {
+ @Test
+ public void testMainHelp() throws Exception {
+ Help help = new Help();
+ String output = help.execute(Mockito.mock(CommandContext.class), null);
+ assertThat(output, containsString("greeting"));
+ assertThat(output, containsString("help"));
+ assertThat(output, containsString("ls"));
+ assertThat(output, containsString("online"));
+ assertThat(output, containsString("offline"));
+ assertThat(output, containsString("quit"));
+ }
+
+ @Test
+ public void testGreeting() throws Exception {
+ Help help = new Help();
+ String output = help.execute(Mockito.mock(CommandContext.class), new
String[]{"greeting"});
+ assertThat(output, containsString("COMMAND NAME"));
+ assertThat(output, containsString("greeting"));
+ assertThat(output, containsString("EXAMPLE"));
+ assertThat(output, containsString("greeting dubbo"));
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/LsTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/LsTest.java
new file mode 100644
index 0000000000..5e75e8626f
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/LsTest.java
@@ -0,0 +1,61 @@
+package org.apache.dubbo.qos.command.impl;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.config.model.ApplicationModel;
+import org.apache.dubbo.config.model.ConsumerModel;
+import org.apache.dubbo.config.model.ProviderModel;
+import org.apache.dubbo.qos.command.CommandContext;
+import org.apache.dubbo.registry.integration.RegistryDirectory;
+import org.apache.dubbo.registry.support.ProviderConsumerRegTable;
+import org.apache.dubbo.registry.support.ProviderInvokerWrapper;
+import org.apache.dubbo.rpc.Invoker;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import java.util.Map;
+
+import static
org.apache.dubbo.registry.support.ProviderConsumerRegTable.getProviderInvoker;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class LsTest {
+ @Test
+ public void testExecute() throws Exception {
+ ConsumerModel consumerModel = mock(ConsumerModel.class);
+
when(consumerModel.getServiceName()).thenReturn("org.apache.dubbo.FooService");
+ ProviderModel providerModel = mock(ProviderModel.class);
+
when(providerModel.getServiceName()).thenReturn("org.apache.dubbo.BarService");
+ ApplicationModel.initConsumerModel("org.apache.dubbo.FooService",
consumerModel);
+ ApplicationModel.initProviderModel("org.apache.dubbo.BarService",
providerModel);
+
+ Invoker providerInvoker = mock(Invoker.class);
+ URL registryUrl = mock(URL.class);
+ when(registryUrl.toFullString()).thenReturn("test://localhost:8080");
+ URL providerUrl = mock(URL.class);
+
when(providerUrl.getServiceKey()).thenReturn("org.apache.dubbo.BarService");
+
when(providerUrl.toFullString()).thenReturn("dubbo://localhost:8888/org.apache.dubbo.BarService");
+ when(providerInvoker.getUrl()).thenReturn(providerUrl);
+ ProviderConsumerRegTable.registerProvider(providerInvoker,
registryUrl, providerUrl);
+ for (ProviderInvokerWrapper wrapper :
getProviderInvoker("org.apache.dubbo.BarService")) {
+ wrapper.setReg(true);
+ }
+
+ Invoker consumerInvoker = mock(Invoker.class);
+ URL consumerUrl = mock(URL.class);
+
when(consumerUrl.getServiceKey()).thenReturn("org.apache.dubbo.FooService");
+
when(consumerUrl.toFullString()).thenReturn("dubbo://localhost:8888/org.apache.dubbo.FooService");
+ when(consumerInvoker.getUrl()).thenReturn(consumerUrl);
+ RegistryDirectory directory = mock(RegistryDirectory.class);
+ Map invokers = Mockito.mock(Map.class);
+ when(invokers.size()).thenReturn(100);
+ when(directory.getUrlInvokerMap()).thenReturn(invokers);
+ ProviderConsumerRegTable.registerConsumer(consumerInvoker,
registryUrl, consumerUrl, directory);
+
+ Ls ls = new Ls();
+ String output = ls.execute(mock(CommandContext.class), null);
+ assertThat(output, containsString("org.apache.dubbo.FooService|100"));
+ assertThat(output, containsString("org.apache.dubbo.BarService| Y"));
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OfflineTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OfflineTest.java
new file mode 100644
index 0000000000..f77085d666
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OfflineTest.java
@@ -0,0 +1,54 @@
+package org.apache.dubbo.qos.command.impl;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.config.model.ApplicationModel;
+import org.apache.dubbo.config.model.ProviderModel;
+import org.apache.dubbo.qos.command.CommandContext;
+import org.apache.dubbo.registry.Registry;
+import org.apache.dubbo.registry.support.ProviderConsumerRegTable;
+import org.apache.dubbo.registry.support.ProviderInvokerWrapper;
+import org.apache.dubbo.rpc.Invoker;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import static
org.apache.dubbo.registry.support.ProviderConsumerRegTable.getProviderInvoker;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.core.Is.is;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class OfflineTest {
+ @Test
+ public void testExecute() throws Exception {
+ ProviderModel providerModel = mock(ProviderModel.class);
+
when(providerModel.getServiceName()).thenReturn("org.apache.dubbo.BarService");
+ ApplicationModel.initProviderModel("org.apache.dubbo.BarService",
providerModel);
+
+ Invoker providerInvoker = mock(Invoker.class);
+ URL registryUrl = mock(URL.class);
+ when(registryUrl.toFullString()).thenReturn("test://localhost:8080");
+ URL providerUrl = mock(URL.class);
+
when(providerUrl.getServiceKey()).thenReturn("org.apache.dubbo.BarService");
+
when(providerUrl.toFullString()).thenReturn("dubbo://localhost:8888/org.apache.dubbo.BarService");
+ when(providerInvoker.getUrl()).thenReturn(providerUrl);
+ ProviderConsumerRegTable.registerProvider(providerInvoker,
registryUrl, providerUrl);
+ for (ProviderInvokerWrapper wrapper :
getProviderInvoker("org.apache.dubbo.BarService")) {
+ wrapper.setReg(true);
+ }
+
+ Registry registry = mock(Registry.class);
+ TestRegistryFactory.registry = registry;
+
+ Offline offline = new Offline();
+ String output = offline.execute(mock(CommandContext.class), new
String[]{"org.apache.dubbo.BarService"});
+ assertThat(output, containsString("OK"));
+ Mockito.verify(registry).unregister(providerUrl);
+ for (ProviderInvokerWrapper wrapper :
getProviderInvoker("org.apache.dubbo.BarService")) {
+ assertThat(wrapper.isReg(), is(false));
+ }
+
+ output = offline.execute(mock(CommandContext.class), new
String[]{"org.apache.dubbo.FooService"});
+ assertThat(output, containsString("service not found"));
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OnlineTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OnlineTest.java
new file mode 100644
index 0000000000..3f5e762cd0
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OnlineTest.java
@@ -0,0 +1,46 @@
+package org.apache.dubbo.qos.command.impl;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.config.model.ApplicationModel;
+import org.apache.dubbo.config.model.ProviderModel;
+import org.apache.dubbo.qos.command.CommandContext;
+import org.apache.dubbo.registry.Registry;
+import org.apache.dubbo.registry.support.ProviderConsumerRegTable;
+import org.apache.dubbo.registry.support.ProviderInvokerWrapper;
+import org.apache.dubbo.rpc.Invoker;
+import org.junit.Test;
+
+import static
org.apache.dubbo.registry.support.ProviderConsumerRegTable.getProviderInvoker;
+import static org.hamcrest.Matchers.equalTo;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class OnlineTest {
+ @Test
+ public void testExecute() throws Exception {
+ ProviderModel providerModel = mock(ProviderModel.class);
+
when(providerModel.getServiceName()).thenReturn("org.apache.dubbo.BarService");
+ ApplicationModel.initProviderModel("org.apache.dubbo.BarService",
providerModel);
+
+ Invoker providerInvoker = mock(Invoker.class);
+ URL registryUrl = mock(URL.class);
+ when(registryUrl.toFullString()).thenReturn("test://localhost:8080");
+ URL providerUrl = mock(URL.class);
+
when(providerUrl.getServiceKey()).thenReturn("org.apache.dubbo.BarService");
+
when(providerUrl.toFullString()).thenReturn("dubbo://localhost:8888/org.apache.dubbo.BarService");
+ when(providerInvoker.getUrl()).thenReturn(providerUrl);
+ ProviderConsumerRegTable.registerProvider(providerInvoker,
registryUrl, providerUrl);
+
+ Registry registry = mock(Registry.class);
+ TestRegistryFactory.registry = registry;
+
+ Online online = new Online();
+ String output = online.execute(mock(CommandContext.class), new
String[]{"org.apache.dubbo.BarService"});
+ assertThat(output, equalTo("OK"));
+ for (ProviderInvokerWrapper wrapper :
getProviderInvoker("org.apache.dubbo.BarService")) {
+ assertTrue(wrapper.isReg());
+ }
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/QuitTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/QuitTest.java
new file mode 100644
index 0000000000..bbfca51ce0
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/QuitTest.java
@@ -0,0 +1,18 @@
+package org.apache.dubbo.qos.command.impl;
+
+import org.apache.dubbo.qos.command.CommandContext;
+import org.apache.dubbo.qos.common.QosConstants;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import static org.hamcrest.Matchers.equalTo;
+import static org.junit.Assert.assertThat;
+
+public class QuitTest {
+ @Test
+ public void testExecute() throws Exception {
+ Quit quit = new Quit();
+ String output = quit.execute(Mockito.mock(CommandContext.class), null);
+ assertThat(output, equalTo(QosConstants.CLOSE));
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/TestRegistryFactory.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/TestRegistryFactory.java
new file mode 100644
index 0000000000..cd222e0aed
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/TestRegistryFactory.java
@@ -0,0 +1,14 @@
+package org.apache.dubbo.qos.command.impl;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.registry.Registry;
+import org.apache.dubbo.registry.RegistryFactory;
+
+public class TestRegistryFactory implements RegistryFactory {
+ static Registry registry;
+
+ @Override
+ public Registry getRegistry(URL url) {
+ return registry;
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/util/CommandHelperTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/util/CommandHelperTest.java
new file mode 100644
index 0000000000..338014c884
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/util/CommandHelperTest.java
@@ -0,0 +1,39 @@
+package org.apache.dubbo.qos.command.util;
+
+import org.apache.dubbo.qos.command.GreetingCommand;
+import org.apache.dubbo.qos.command.impl.Help;
+import org.apache.dubbo.qos.command.impl.Ls;
+import org.apache.dubbo.qos.command.impl.Offline;
+import org.apache.dubbo.qos.command.impl.Online;
+import org.apache.dubbo.qos.command.impl.Quit;
+import org.hamcrest.Matchers;
+import org.junit.Test;
+
+import java.util.List;
+
+import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.hamcrest.Matchers.equalTo;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertTrue;
+
+public class CommandHelperTest {
+ @Test
+ public void testHasCommand() throws Exception {
+ assertTrue(CommandHelper.hasCommand("greeting"));
+ assertFalse(CommandHelper.hasCommand("not-exiting"));
+ }
+
+ @Test
+ public void testGetAllCommandClass() throws Exception {
+ List<Class<?>> classes = CommandHelper.getAllCommandClass();
+ assertThat(classes, containsInAnyOrder(GreetingCommand.class,
Help.class, Ls.class, Offline.class, Online.class, Quit.class));
+ }
+
+ @Test
+ public void testGetCommandClass() throws Exception {
+ assertThat(CommandHelper.getCommandClass("greeting"),
equalTo(GreetingCommand.class));
+ assertNull(CommandHelper.getCommandClass("not-exiting"));
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/protocol/QosProtocolWrapperTest.java
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/protocol/QosProtocolWrapperTest.java
new file mode 100644
index 0000000000..d01df2de96
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/protocol/QosProtocolWrapperTest.java
@@ -0,0 +1,60 @@
+package org.apache.dubbo.qos.protocol;
+
+import org.apache.dubbo.common.Constants;
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.qos.command.BaseCommand;
+import org.apache.dubbo.qos.server.Server;
+import org.apache.dubbo.rpc.Invoker;
+import org.apache.dubbo.rpc.Protocol;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class QosProtocolWrapperTest {
+ private URL url = Mockito.mock(URL.class);
+ private Invoker invoker = mock(Invoker.class);
+ private Protocol protocol = mock(Protocol.class);
+ private QosProtocolWrapper wrapper = new QosProtocolWrapper(protocol);
+ private Server server = Server.getInstance();
+
+ @Before
+ public void setUp() throws Exception {
+ when(url.getParameter(Constants.QOS_ENABLE,
"true")).thenReturn("true");
+ when(url.getParameter(Constants.QOS_PORT,
"22222")).thenReturn("12345");
+ when(url.getParameter(Constants.ACCEPT_FOREIGN_IP,
"true")).thenReturn("false");
+ when(invoker.getUrl()).thenReturn(url);
+ when(url.getProtocol()).thenReturn(Constants.REGISTRY_PROTOCOL);
+ }
+
+ @After
+ public void tearDown() throws Exception {
+ if (server.isStarted()) {
+ server.stop();
+ }
+ }
+
+ @Test
+ public void testExport() throws Exception {
+ wrapper.export(invoker);
+ assertThat(server.isStarted(), is(true));
+ assertThat(server.getPort(), is(12345));
+ assertThat(server.isAcceptForeignIp(), is(false));
+ verify(protocol).export(invoker);
+ }
+
+ @Test
+ public void testRefer() throws Exception {
+ wrapper.refer(BaseCommand.class, url);
+ assertThat(server.isStarted(), is(true));
+ assertThat(server.getPort(), is(12345));
+ assertThat(server.isAcceptForeignIp(), is(false));
+ verify(protocol).refer(BaseCommand.class, url);
+ }
+}
diff --git
a/dubbo-plugin/dubbo-qos/src/test/resources/META-INF/services/org.apache.dubbo.registry.RegistryFactory
b/dubbo-plugin/dubbo-qos/src/test/resources/META-INF/services/org.apache.dubbo.registry.RegistryFactory
new file mode 100644
index 0000000000..a431677c9c
--- /dev/null
+++
b/dubbo-plugin/dubbo-qos/src/test/resources/META-INF/services/org.apache.dubbo.registry.RegistryFactory
@@ -0,0 +1 @@
+test=org.apache.dubbo.qos.command.impl.TestRegistryFactory
\ No newline at end of file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
