kimmking commented on a change in pull request #1994: avro serialization implement URL: https://github.com/apache/incubator-dubbo/pull/1994#discussion_r198241921
########## File path: dubbo-serialization/dubbo-serialization-avro/pom.xml ########## @@ -0,0 +1,25 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.dubbo</groupId> + <artifactId>dubbo-serialization</artifactId> + <version>2.7.0-SNAPSHOT</version> + </parent> + <artifactId>dubbo-serialization-avro</artifactId> + <name>${project.artifactId}</name> + <description>The common module of dubbo project</description> + + <dependencies> + <dependency> + <groupId>org.apache.dubbo</groupId> + <artifactId>dubbo-serialization-api</artifactId> + <version>${project.parent.version}</version> + </dependency> + <dependency> + <groupId>org.apache.avro</groupId> + <artifactId>avro</artifactId> + <version>1.8.2</version> Review comment: move version to dependency-bom ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
