diecui1202 commented on a change in pull request #2196: Adding AbstractRegistry test cases URL: https://github.com/apache/incubator-dubbo/pull/2196#discussion_r208101243
########## File path: dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/support/AbstractRegistryTest.java ########## @@ -0,0 +1,222 @@ +package org.apache.dubbo.registry.support; + +import org.apache.dubbo.common.URL; +import org.apache.dubbo.registry.NotifyListener; +import org.hamcrest.Matchers; +import org.junit.Assert; +import org.junit.Test; + +import java.util.*; Review comment: It's not a good practice to import *. Import that you need. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
