guangqianpeng commented on a change in pull request #2197: [Dubbo-#2184] Return 
the hanging client requests immediately when connection is broken #2184
URL: https://github.com/apache/incubator-dubbo/pull/2197#discussion_r208158763
 
 

 ##########
 File path: 
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java
 ##########
 @@ -107,6 +107,13 @@ public static void received(Channel channel, Response 
response) {
         }
     }
 
+    public static void disconnected(Channel channel) {
 
 Review comment:
   No. This method just wake up all the threads that are awaiting a 
DefaultFuture done or timeout. If the waken up thread find the channel is 
disconnected, it will throw a RemoteException.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to