diecui1202 closed pull request #2145: FailoverClusterInvoker 使用泛化调用时，拿取正确的方法名称。
URL: https://github.com/apache/incubator-dubbo/pull/2145
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java
b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java
index 00b981fd20..b3aa31099f 100644
---
a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java
+++
b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java
@@ -28,6 +28,7 @@
import org.apache.dubbo.rpc.RpcException;
import org.apache.dubbo.rpc.cluster.Directory;
import org.apache.dubbo.rpc.cluster.LoadBalance;
+import org.apache.dubbo.rpc.support.RpcUtils;
import java.util.ArrayList;
import java.util.HashSet;
@@ -54,7 +55,8 @@ public FailoverClusterInvoker(Directory<T> directory) {
public Result doInvoke(Invocation invocation, final List<Invoker<T>>
invokers, LoadBalance loadbalance) throws RpcException {
List<Invoker<T>> copyinvokers = invokers;
checkInvokers(copyinvokers, invocation);
- int len = getUrl().getMethodParameter(invocation.getMethodName(),
Constants.RETRIES_KEY, Constants.DEFAULT_RETRIES) + 1;
+ String methodName = RpcUtils.getMethodName(invocation);
+ int len = getUrl().getMethodParameter(methodName,
Constants.RETRIES_KEY, Constants.DEFAULT_RETRIES) + 1;
if (len <= 0) {
len = 1;
}
@@ -77,7 +79,7 @@ public Result doInvoke(Invocation invocation, final
List<Invoker<T>> invokers, L
try {
Result result = invoker.invoke(invocation);
if (le != null && logger.isWarnEnabled()) {
- logger.warn("Although retry the method " +
invocation.getMethodName()
+ logger.warn("Although retry the method " + methodName
+ " in the service " + getInterface().getName()
+ " was successful by the provider " +
invoker.getUrl().getAddress()
+ ", but there have been failed providers " +
providers
@@ -100,7 +102,7 @@ public Result doInvoke(Invocation invocation, final
List<Invoker<T>> invokers, L
}
}
throw new RpcException(le != null ? le.getCode() : 0, "Failed to
invoke the method "
- + invocation.getMethodName() + " in the service " +
getInterface().getName()
+ + methodName + " in the service " + getInterface().getName()
+ ". Tried " + len + " times of the providers " + providers
+ " (" + providers.size() + "/" + copyinvokers.size()
+ ") from the registry " + directory.getUrl().getAddress()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
