chickenlj commented on issue #2213: [Dubbo-2187] Use CompletetableFuture to 
rewrite the embedded ListenableFuture
URL: https://github.com/apache/incubator-dubbo/pull/2213#issuecomment-411994287
 
 
   ```java
    public void addListener(final IZkStateListener listener) {
           completableFuture.whenComplete((v,e)->{
               client = v;
               client.subscribeStateChanges(listener);
   
           });
       }
   ```
   
   I think we should consider possible Exceptions that may come up here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to