lexburner opened a new pull request #2228: [Dubbo- support tag router feature] 
Add a new Router implement -- TagRouter
URL: https://github.com/apache/incubator-dubbo/pull/2228
 
 
   ## What is the purpose of the change
   
   Support tag router feature for dubbo.
   
   ## Brief changelog
   
   - add unit property for dubbo.xsd.
   - add TagRouter,TagRouterFactory.
   - add SPI statement for adding TagRouter automatically.
   - fix a small bug(may be not) in 
`org.apache.dubbo.registry.integration.RegistryDirectory#route`,exclude runtime 
routers, avoid to filter some runtime invokers.
   
   ## Verifying this change
   
   Here is more detail about Unit Test:
   `org.apache.dubbo.rpc.cluster.router.tag.TagRouterTest`
   I have verified that the unit test has been correct and passed.
   
   Here is more detail about a Integration Test:
   clone the repository 
`https://github.com/lexburner/Dubbo-Sample-TagRouter.git`,can see the route tag 
feature.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist #XXX`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile 
failsafe:integration-test` to make sure unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to