diecui1202 commented on issue #2547: Logical Error in ForkingClusterInvoker? URL: https://github.com/apache/incubator-dubbo/issues/2547#issuecomment-424269467 I checked the select method again, it can not make sure return a new invoker, check this method: org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker#reselect, use invokers not in `selected` first, if all invokers are in `selected`, just pick an available one using loadbalance policy. So in order to make sure the `selected` are different, the if statement is required. With the context of org.apache.dubbo.rpc.cluster.support.ForkingClusterInvoker#doInvoke, IMO, it won't get less forks, and the if statement improves code robustness.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
