AlbumenJ commented on code in PR #15364:
URL: https://github.com/apache/dubbo/pull/15364#discussion_r2083714799
##########
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/StubServiceDescriptor.java:
##########
@@ -96,6 +98,14 @@ public MethodDescriptor getMethod(String methodName, String
params) {
*/
public MethodDescriptor getMethod(String methodName, Class<?>[]
paramTypes) {
List<MethodDescriptor> methodModels = methods.get(methodName);
+ if (methodModels == null) {
+ for (Entry<String, List<MethodDescriptor>> entry :
methods.entrySet()) {
+ if (methodName.equalsIgnoreCase(entry.getKey())) {
Review Comment:
1. Performance degradation
2. This is a breaking change for old-users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
