Whitea029 opened a new issue, #2885:
URL: https://github.com/apache/dubbo-go/issues/2885

   ### Environment
   
   - Server: Dubbo-go, v3.3.0
   - Client: Dubbo-go, v3.3.0
   - Protocol: Triple
   
   ### Issue description
   
   
`client/options.go`中`WithClientFilter`Filter只注册到了`Consumer`上,并没有注册到`overallReference`上,导致Filter不生效
   ``` go
   func WithClientFilter(filter string) ClientOption {
        return func(opts *ClientOptions) {
                // todo: move this to overallReference
                opts.Consumer.Filter = filter
        }
   }
   ```
   
   ### Solutions
   
   是否有必要在`WithClientFilter`添加`overallReference`的注册
   
https://github.com/apache/dubbo-go/blob/0ba792a48728b278c910fabb251d0a82e96e9bae/client/options.go#L546C1-L552C2
   ``` go
    opts.overallReference.Filter = filter
   ```
   或者修改`client/action.go`中的`getURLMap`方法
   
https://github.com/apache/dubbo-go/blob/0ba792a48728b278c910fabb251d0a82e96e9bae/client/action.go#L362C1-L374C1
   ``` go
   urlMap.Set(constant.ReferenceFilterKey, commonCfg.MergeValue(ref.Filter, 
refOpts.Consumer.Filter, defaultReferenceFilter))
   ```
   
   如果是可行的,我愿意提交相关的PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to