Alanxtl commented on code in PR #847:
URL: https://github.com/apache/dubbo-go-samples/pull/847#discussion_r2108246343
##########
llm/go-server/cmd/server.go:
##########
@@ -43,30 +46,24 @@ import (
var cfg *config.Config
type ChatServer struct {
- llms map[string]*ollama.LLM
+ llm *ollama.LLM
}
func NewChatServer() (*ChatServer, error) {
+ if cfg.ModelName == "" {
+ return nil, fmt.Errorf("MODEL_NAME environment variable is not
set")
+ }
Review Comment:
put this check in `config.go` instead of here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
