marsevilspirit commented on code in PR #2900: URL: https://github.com/apache/dubbo-go/pull/2900#discussion_r2113178520
########## global/protocol_client_config.go: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package global + +import ( + "dubbo.apache.org/dubbo-go/v3/common/constant" +) + +// TODO: find a better name replace ProtocolClientConfig Review Comment: ProtocolClientConfig (tentative) is at the same level as the server's ProtocolConfig in terms of configuration. ProtocolClientConfig includes but is not limited to TripleConfig. In the future, this structure will provide more flexible configuration and options for more parameters. TripleConfig is one layer below ProtocolClientConfig. I am considering dividing TripleConfig into two parts: Server and Client, to achieve separation of server and client options at the Triple level. Therefore, calling it TripleClientConfig is not a good choice. We currently do not support multi-protocol client configuration, or in other words, we are still unsure whether we should support multi-protocol clients, so ClientProtocolsConfig is not being considered for the time being. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
