marsevilspirit commented on code in PR #2900:
URL: https://github.com/apache/dubbo-go/pull/2900#discussion_r2114169103
##########
options.go:
##########
@@ -378,8 +378,27 @@ func WithMetadataServiceProtocol(protocol string)
InstanceOption {
}
}
-func WithProtocol(opts ...protocol.Option) InstanceOption {
- proOpts := protocol.NewOptions(opts...)
+// TODO: deal this fuction
+// this function I want handle the protocol.Option which
+// both server and client can use together.
+// like:
+//
+// func WithProtocol(opts ...protocol.Option) InstanceOption {
+// proOpts := protocol.NewOptions(opts...)
+//
+// log.Warnf("proOpts: %+v", proOpts)
+//
+// return func(insOpts *InstanceOptions) {
+// if insOpts.Protocols == nil {
+// insOpts.Protocols =
make(map[string]*global.ProtocolConfig)
+// }
+// insOpts.Protocols[proOpts.ID] = proOpts.Protocol
+// }
+// }
+//
+// but now only work in server side fot compat old API.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
