Alanxtl commented on code in PR #688:
URL: https://github.com/apache/dubbo-go-pixiu/pull/688#discussion_r2176324902


##########
pkg/model/listener.go:
##########
@@ -71,4 +79,45 @@ type (
                FilterChain FilterChain  `yaml:"filter_chains" 
json:"filter_chains" mapstructure:"filter_chains"`
                Config      any          `yaml:"config" json:"config" 
mapstructure:"config"`
        }
+
+       // GrpcConfig gRPC listener specific configuration
+       GrpcConfig struct {
+               MaxReceiveMessageSize int        
`yaml:"max_receive_message_size" json:"max_receive_message_size" 
mapstructure:"max_receive_message_size"`
+               MaxSendMessageSize    int        `yaml:"max_send_message_size" 
json:"max_send_message_size" mapstructure:"max_send_message_size"`
+               EnableCompression     bool       `yaml:"enable_compression" 
json:"enable_compression" mapstructure:"enable_compression"`
+               IdleTimeout           string     `yaml:"idle_timeout" 
json:"idle_timeout" mapstructure:"idle_timeout"`
+               MaxConnectionAge      string     `yaml:"max_connection_age" 
json:"max_connection_age" mapstructure:"max_connection_age"`
+               EnableTLS             bool       `yaml:"enable_tls" 
json:"enable_tls" mapstructure:"enable_tls"`
+               TLS                   *TLSConfig `yaml:"tls,omitempty" 
json:"tls,omitempty" mapstructure:"tls,omitempty"`
+       }

Review Comment:
   it depends on whether you need a default value, see pkg/model/base.go:90



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to